Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes terraform-provider-google#13266 Add Firebase label for all examples that creates a new Firebase Project #13552

Conversation

modular-magician
Copy link
Collaborator

Fixes #13266

When google_firebase_project is used, it adds a label firebase:enabled to the underlying GCP project. This label will be accidentally deleted when running terraform apply again because the label isn't present in the google_project resource block. This has caused Firebase projects created in Terraform to not show in the Firebase Console and Firebase CLI.

While we can't 100% prevent users from deleting the label, at least the examples should be correct.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_project: fixes misleading examples that could cause `firebase:enabled` label to be accidentally removed.

Derived from GoogleCloudPlatform/magic-modules#7149

…ples that creates a new Firebase Project (hashicorp#7149)

Fixes hashicorp#13266

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit b63a1e3 into hashicorp:main Jan 23, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccFirebaseWebApp_firebaseWebAppFull
1 participant